Skip to content

🌱 Fix update-golangci-lint permissions #2748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2025
Merged

🌱 Fix update-golangci-lint permissions #2748

merged 1 commit into from
Oct 3, 2025
+1 −0

Conversation

lentzi90
Copy link
Contributor

@lentzi90 lentzi90 commented Oct 2, 2025

What this PR does / why we need it:

This workflow needs more permissions. There is an example in the docs: https://github.com/peter-evans/create-pull-request
We were missing contents: write.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2747

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 2, 2025
@netlify Netlify
Copy link

netlify bot commented Oct 2, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit ea40d34
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/68de7b9545f1aa0007e73068
😎 Deploy Preview https://deploy-preview-2748--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 2, 2025
@lentzi90
Copy link
Contributor Author

lentzi90 commented Oct 2, 2025

/cc @smoshiur1237

@lentzi90
Copy link
Contributor Author

lentzi90 commented Oct 3, 2025

Ok this doesn't fully work yet. It can now push the changes but not open the PR.
I have tested it (by pushing a branch where I can trigger the workflow) here: https://github.com/kubernetes-sigs/cluster-api-provider-openstack/actions/runs/18214075898
At least we can then manually create the PR this way.

@smoshiur1237
Copy link
Contributor

PR looks okay, would you check and enable this behavior on the organization level and then on the repository level

@lentzi90
Copy link
Contributor Author

lentzi90 commented Oct 3, 2025

Looks like it is disabled in the repo settings and I cannot change it. Probably org policy then.
I think we should then anyway merge this so he workflow can push the branch. Then we can check when it fails and open PRs manually

@smoshiur1237
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2025
@lentzi90
Copy link
Contributor Author

lentzi90 commented Oct 3, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit 4380b20 into kubernetes-sigs:main Oct 3, 2025
11 of 12 checks passed
@github-project-automation github-project-automation bot moved this from Inbox to Done in CAPO Roadmap Oct 3, 2025
@lentzi90 lentzi90 deleted the lentzi90/workflow-permissions branch October 3, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilienM EmilienM Awaiting requested review from EmilienM

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

Assignees

@smoshiur1237 smoshiur1237

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
CAPO Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update golangci-lint workflow lacks permissions
3 participants
@lentzi90 @smoshiur1237 @k8s-ci-robot